Jump to content

Miami

Member
  • Content Count

    30
  • Joined

  • Last visited

  • Days Won

    5

Posts posted by Miami


  1. Actual result:

    When aggressive mob appears and character is in aggro range the mob starts to attack immediately on spawn. The same situation with social mobs. If you're attacking mob-1 and then mob-2 (social to 1) appears nearby it starts to attack immediately.

    Expected result:

    Aggro/social mob should have some inner cooldown on "scanning" the targets to attack in aggro radius. For example, if character stand in position and aggro mob appears rightΒ  at chaacter so it shouldn't attack until character moves out of aggro radius and come back to it. Social mob also should "scan" the social radius with cooldown to see if any social mob is being attacked or not and this "scanning" should start happenning not on mob's spawn, but some time after.

    You can see the comparison of behavior between L2OFF and L2jOrion on videos below:

    L2OFF (AdvExt)Β aggro -

    You must be signed in to view the link content in this post. Please Sign In or Sign Up.

    L2jOrion aggro -
    You must be signed in to view the link content in this post. Please Sign In or Sign Up.

    • Thanks 1

  2. I noticedΒ  the issue when your skill could be used even if you actually have not activated it via clicking it's icon or pressing a key.Β 

    So the steps to reproduce are:

    1. Target any mob
    2. Press key to activate it and hold it pressing until mob dies
    3. target another mob
    4. do the autoattack and DO NOT press any other skill keys

    Actual result:

    Skill is included in attack sequence order for the second mob as well even if it is not needed

    Expected result:

    Attack sequence of skills/actions (which have been activated while mob-1 was alive)Β should be wiped after the first mob dies. I've checked this behavior on C4 PTS and it works as expected.

    You must be signed in to view the link content in this post. Please Sign In or Sign Up.
    - here you can see I pressed and held the key for the first mob, but then I have not pressed any skill for the second one and IronPunch has been used after couple of autoattacks (so it is even was not the first action in attack sequence)

    P.S. it is not related to the latest fix of soulshots sequence. I've checked with old and new core files and issue is present in both versions.

    • Thanks 1

  3. Here is the manually cleanedΒ namelist.txt for bots

    I've removed the following:

    • weird names like `11111`,Β  `sdfsdfsdf`
    • doubling names like `name1`, `name2`, `name3`
    • restricted names like `nigger`, `nazi`

    Almost 4kΒ names removed so now the list looks more real names like. Ofc not all weird names removed, but I tried my best to walk through all 32k names and clean everything weird.

    namelist.txt

    • Like 1
    • Thanks 3

  4. Epic bosses random respawn just takes RESP_FIRST and random RESEP_SECOND without random of minutes and seconds. So basically if we have the following config for Baium respawn

    # Hours:
    BaiumRespFirst = 120
    # +Random Hours:
    BaiumRespSecond = 8

    in this case the random respawn will be one of these: 120 hrs / 121 / 122 / 123 / 124 / 125 / 126 / 127 / 128 hrs, but it should take into account the random minutes and seconds within hours so we could have 122 hrs, 14 minutes and 48 seconds of random.

    Screenshot for reference:

    image.thumb.png.65747b8b15e004767d81642d8a3bdd93.png


  5. Soulshots activating order sequence does not match the L2OFF. Shots should be activated after each hit, but not the before hit.

    Lets check how the shots are working , for example, when you try to kill two mobs and compare the behavior with L2OFF. So you can see that order sequence of shots enabling is slightly different.

    L2jOrion (

    You must be signed in to view the link content in this post. Please Sign In or Sign Up.
    Β )

    1. Autouse soulshots activated
    2. Attack mob-1
    3. Damage done
    4. Shots enabled
    5. Damage done
    6. Shots enabled
    7. Damage done
    8. Mob-1 killed
    9. Attack mob-2
    10. Shots enabled
    11. Damage done
    12. Shots enabled
    13. Damage done
    14. Shots enabled
    15. Damage done
    16. Mob-2 killed

    L2OFF (

    You must be signed in to view the link content in this post. Please Sign In or Sign Up.
    Β )

    1. Autouse soulshots activated
    2. Attack mob-1
    3. Damage done
    4. Shots enabled
    5. Damage done
    6. Shots enabled
    7. Damage done
    8. Mob-1 killed
    9. Shots enabled
    10. Attack mob-2
    11. Damage done
    12. Shots enabled
    13. Damage done
    14. Shots enabled
    15. Damage done
    16. Shots enabled
    17. Mob-2 killed

  6. There are a lot of errors appeared when I enabled and configured bots for my server.

    Bots are created and looks functioning, but that flood in error log is annoying.

    Here are the examples of errors

    java.lang.NullPointerException: Cannot invoke "l2jorion.game.model.L2Skill.getEffects(l2jorion.game.model.L2Character, l2jorion.game.model.L2Character)" because the return value of "l2jorion.game.datatables.SkillTable.getInfo(int, int)" is null
            at l2jorion.bots.ai.FakePlayerAI.applyDefaultBuffs(FakePlayerAI.java:88)
            at l2jorion.bots.ai.classes.newbie.ElvenMageAI.thinkAndAct(ElvenMageAI.java:34)
            at l2jorion.bots.task.AITask.lambda$run$1(AITask.java:27)
            at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
            at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
            at java.base/java.util.ArrayList$SubList$2.forEachRemaining(ArrayList.java:1481)
            at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
            at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
            at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
            at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
            at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
            at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
            at l2jorion.bots.task.AITask.run(AITask.java:27)
            at l2jorion.game.thread.ThreadPoolManager$RunnableWrapper.run(ThreadPoolManager.java:57)
            at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
            at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
            at java.base/java.lang.Thread.run(Thread.java:833)

    Β 

    java.lang.NullPointerException: Cannot invoke "l2jorion.game.model.L2Skill.getCastRange()" because "skill" is null
            at l2jorion.bots.ai.CombatAI.waitAndPickAvailablePrioritisedSpell(CombatAI.java:526)
            at l2jorion.bots.ai.CombatAI.getRandomAvailableMageSpellForTarget(CombatAI.java:514)
            at l2jorion.bots.ai.CombatAI.tryAttackingUsingMageOffensiveSkill(CombatAI.java:33)
            at l2jorion.bots.ai.classes.newbie.ElvenMageAI.thinkAndAct(ElvenMageAI.java:37)
            at l2jorion.bots.task.AITask.lambda$run$1(AITask.java:27)
            at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
            at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
            at java.base/java.util.ArrayList$SubList$2.forEachRemaining(ArrayList.java:1481)
            at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
            at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
            at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
            at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
            at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
            at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
            at l2jorion.bots.task.AITask.run(AITask.java:27)
            at l2jorion.game.thread.ThreadPoolManager$RunnableWrapper.run(ThreadPoolManager.java:57)
            at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
            at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
            at java.base/java.lang.Thread.run(Thread.java:833)

    Attaching also my bot.ini file.

    Β 

    bot.ini

    • Thanks 1

  7. Affected functionality:

    ClanHall auction bidders list window

    Actual result:

    Anyone can open bidders list and see the bid value of any clan for clan hall

    Expected result:

    Only clan member and academy member can see current clan's bid and should not see other clans bid values.

    Screenshot for reference:

    image.png.925d85bf6323b2629d49400482708c28.png

    • Thanks 1

Γ—